Help finding how logger, Test.adapter.exception and onerror have changed


#1

I’m upgrading an app from 2.18 to 3.4 and I could use some help finding how the following methods have changed:

Ember.Logger.error
Ember.Test.adapter.exception
Ember.onerror

I’m using them to test for asynchronous errors as described in this article.

So far I’ve found this code which suggests Ember is moving completely to console.[log/warn/info/error] functionality, but I haven’t been able to pinpoint any commit/release in the CHANGELOG over when this happened and if it can be safely assumed that all prior uses of Logger/adapter.exception/onerror have been replaced.

Could someone point me in the right direction? Thanks!


#2

Other than "just use console.debug()", I’m not sure if there was anything else to it.

Initial mention of the deprecation from Tom: https://github.com/emberjs/rfcs/pull/176#issuecomment-272566327

RFC: https://github.com/emberjs/rfcs/blob/b64b6df30483cb7a0ce39dc651d28b30a8b13bc3/text/0297-deprecate-ember-logger.md

Issue to track the removal: https://github.com/emberjs/ember.js/issues/16231

Deprecation guide: https://emberjs.com/deprecations/v3.x#toc_ember-console-deprecate-logger


#3

Can you provide an example test? I’m sure we can make it work well, but for me its always better to focus on a specific reproduction rather than talk about generalities…


#4

@rwjblue I was using this code to test async errors in my tests. I’m not sure which (if any) of lines 9-11 I need anymore.