Code Review For Training Tomorrow


#1

Hi Everyone,

I’ll be doing some ember training shortly and I’d really love some feedback on the application I’m having the students build. Its extremely important that I show them the best way to build the app and any feedback is appreciated.

The code can be found up on GitHub at https://github.com/bittersweetryan/mello.

Thanks! Ryan


#2

Great example app!

Just one question as an Ember noob: why use DS.attr( ) whitout specifing a type? Does it have any downsides?


#3

@alpacaaa Without specifying a type Ember will try to determine what it is based on the server’s payload. Specifying a type will always try to coerce it to that type: http://emberjs.com/guides/models/defining-models/


#4

Ok cool! I’ve been digging into the code and found it very useful, thanks for sharing :slight_smile: