Why add domain in `ember-cli-content-security-policy` and not in `ember-cli-inject-live-reload`?

broerse · October 19, 2014, 10:59am

Why is this:

if (options.liveReload) {
  ['localhost', '0.0.0.0'].forEach(function(host) {
    headerConfig['connect-src'] = headerConfig['connect-src'] + ' ws://' + host + ':' + options.liveReloadPort;
    headerConfig['script-src'] = headerConfig['script-src'] + ' ' + host + ':' + options.liveReloadPort;
  });
}

done in ember-cli-content-security-policy and not in ember-cli-inject-live-reload ? I ask this because it is seems more logical to me to let it be inserted by the module that uses the external connect-src. I like in :

github.com

broerse/ember-cli-blog/blob/master/app/adapters/application.js

import config from '../config/environment';
import PouchDB from 'ember-pouch/pouchdb';
import { Adapter } from 'ember-pouch';
import { assert } from '@ember/debug';
import { isEmpty } from '@ember/utils';
import { inject as service } from '@ember/service';
import auth from 'pouchdb-authentication';

PouchDB.plugin(auth);

export default class ApplicationAdapter extends Adapter {
  @service store;
  @service session;
  @service cloudState;
  @service refreshIndicator;

  constructor() {
    super(...arguments);

    const localDb = config.local_couch || 'blogger';

This file has been truncated. show original

EmberPouch to inject the domains in connect-src. This seems better to me than adding if (options.liveReload) and if (options.EmberPouch) to the ember-cli-content-security-policy. Perhaps it done for booting ember-cli-content-security-policy and will it move in the future so all adapter makers can do inject connect-src the same way as ember-cli-inject-live-reload. If you do it by hand in your config environment it works as long as the adapter uses static domains/ports. I have no problem with the current setup but was just wondering why.

Topic		Replies	Views
GET https://app-name.local/livereload.js net::ERR_ABORTED 404 (Not Found) Ember CLI	1	2771	February 5, 2019
Is it possible to use Ember CLI's Live Reload support from Nitrious.io? Ember CLI	10	5128	October 6, 2014
Security problems in upgrading ember application	2	1288	May 19, 2015
Help Resolving error: [Report Only] Refused to load the script Ember CLI	1	8808	December 12, 2014
Deployment of ember frontend with rails backend Ember CLI	2	729	September 21, 2021

Why add domain in `ember-cli-content-security-policy` and not in `ember-cli-inject-live-reload`?

Related topics