Thanks! For anyone following up here in the future, the repo has moved to GitHub - ember-learn/discourse-emberjs-theme: Forum theme for https://discuss.emberjs.com/
3 Likes
I’ve made some quick theme fixes today, as it’s been a while and the theme has fallen behind with some Discourse updates over the years.
The theme’s CSS is a bit of a mess at the moment, so I think I’ll refactor it soon to clean it up and fix some other lingering issues. I’ll also be able to enable a dark mode option by doing this.
Aside from fixing styling problems should things be updated to better match https://emberjs.com/ again? (using black for the header for example)
7 Likes
I think matching the style of the main website is an awesome idea! @Jared_Galanis or @locks would be good folks to run that past.
3 Likes
One of my teammates also noticed that Twitter login no longer works, and Github auth is tied to @eviltrout’s account (he’s no longer actively working on Discourse) — neither of these are emergencies, but if anyone knows who the best contact is for getting those cleaned up we can help out there as well.
1 Like
@ef4 or @katiegengler as members of the steering committee are good options there
2 Likes
I’ve just added a first pass at a theme that better matches the current website.
If you want to try it out you can head over to https://discuss.emberjs.com/my/preferences/interface and select it from the theme dropdown
The theme is fairly simple and should encounter fewer regressions along the way vs the current theme.
I’ve included the nav and footer from https://emberjs.com/
A couple things to note:
-
the site logo is global for all themes… so when the new theme is ready to become the default, I can swap the white ember discuss logo out for the red one.
-
the new theme was built to support an optional dark mode… enabling dark mode will likely break the current theme so I can’t enable it for previewing here… but it would look like this (screenshots from my dev environment)
Let me know what you think!
7 Likes
This is very nice. I’m using the light-theme, and it’s stellar! nice work!!
4 Likes
Agree, just enabled it and it looks awesome. The header and footer updates are a really nice touch too. Thank you!
3 Likes
Oh and once everyone’s cool with making this the default, I can transfer the repo to ember-learn on github, at the moment it’s on my personal account: GitHub - awesomerobot/discourse-ember-2023-theme
4 Likes
It’s been a couple weeks, would anyone else need to see/approve the updated theme? I can transfer it over to the Ember Learning Team · GitHub and get it enabled as the default here whenever!
2 Likes
No need for anyone else to see it, it’s awesome and clearly a massive improvement! I can probably help you get it transferred 
Remind me what I need to do 
do I need to add you to the org temporarily?
2 Likes
The best way is for @awesomerobot to add you to the repo as an owner and then you transfer it over.
[edit] I checked the backlog and we already had a theme repository at GitHub - ember-learn/discourse-emberjs-theme: Forum theme for https://discuss.emberjs.com/, so a PR there would be an alternative!
2 Likes
Oh yes, a PR streamlines the process:
5 Likes
does this look ok to merge? (it’s been merged)
6 Likes