Why are the RESTAdapter tests commented out in ember-data?

Ember Data
1

I noticed ember-data went to rev 12 yesterday and before I upgraded my adapter I pulled down the latest source to see what had changed since rev 11 and the first thing that jumped out was that this file

ember-data/tests/integration/rest_adapter_test.js

has every test commented out … so I’m curious if this means the RESTAdapter is in flux or if another test suite has been added recently to cover the basics? Or something else is on the road map?

If it’s just in flux why did the version get a bump to 12? I would assume the RESTAdapter would at the very least be functional with a version bump. What’s up and what can I do to help?

3 Likes
2

Good question. @wycats, @tom?

3

I think they are back in now (when rev 12 was started I noticed they were not on sadly)

4

Assuming you are talking about packages/ember-data/tests/integration/rest_adapter_test.js, it is still a file full of comments.

5

ah (could have sworn it was back in action) - anyone care to comment on this? I know it was because of a merge conflict ~4 months ago

https://github.com/emberjs/data/commit/aabbcd6e3d87bc02d826f1044e91811e111a1456

6

Yeah I had this question couple of times myself :panda_face: