Force build failure on any JShint Error

ramybenaroya · January 11, 2015, 10:28am

Is there a way to define ember-cli build tolerance for JSHint errors?
For example, when JSHint only raises an undefined variable error, the build supposed to fail.
Thanks.

jasonmit · January 12, 2015, 6:30am

I don’t believe this is yet supported. However, you could throw an exception here instead of a log – which will effectively stop the build.

https://github.com/rwjblue/broccoli-jshint/blob/master/index.js#L39

In any case, this would make for a great pull request to optionally prevent the write when an error occurred.

ramybenaroya · January 12, 2015, 11:11am

This is great, thanks. I submitted a PR, but I decided to throw the error in an earlier stage at JSHinter.prototype.processString.

github.com

rwjblue/broccoli-jshint/blob/master/index.js#L53


      
          
          
JSHinter.prototype.build = function () {
            var self = this;
            self._errors = [];
          
          
  if (!self.jshintrc) {
              var jshintPath = self.jshintrcPath || path.join(this.inputPaths[0], self.jshintrcRoot || '');
              self.jshintrc = self.getConfig(jshintPath);
            }
          
          
  return Filter.prototype.build.call(this)
            .finally(function() {
              if (self._errors.length > 0) {
                var label = ' JSHint Error' + (self._errors.length > 1 ? 's' : '');
                self.console.log('\n' + self._errors.join('\n'));
                self.console.log(chalk.yellow('===== ' + self._errors.length + label + '\n'));
              }
            });
          };
          
          
JSHinter.prototype.processString = function (content, relativePath) {

This is because JSHinter.prototype.write is never reached when JSHinter is passed with a custom logError method, which what happens in the tests (to avoid dirty error messages in the tests log).

ado_rum · June 10, 2016, 7:07am

Hi guys, PR is already merged into broccoli-jshint. Is it possible somehow implement failOnAnyError flag to ember-cli-build.js to enable this feature? Thanks

hschmidt99 · July 13, 2016, 7:45am

I modified my ember-cli-build.js in the following way to make use of the new option:

var EmberApp = require('ember-cli/lib/broccoli/ember-app'); var jsHint = require('broccoli-jshint'); jsHint.prototype.failOnAnyError = true;

I admit it feels ugly to have to touch the prototype and am grateful for better suggestions.

EDIT: I just realized this is still gonna pose a problem for environment===‘production’, since jsHint seems to be completely switched off for that environment

Topic		Replies	Views
Force build failure on any ESLint Error Ember CLI	2	1859	June 23, 2017
JsHint errors only reported once Ember CLI	3	1720	March 9, 2016
Why does ember-cli not evaluate .jshintrc? Ember CLI	0	1022	February 6, 2015
.jshintrc predef errors Ember CLI	3	831	September 30, 2017
Debugging failures in uglifyjs? Ember CLI	6	6210	February 25, 2016

Force build failure on any JShint Error

Related topics